Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shuffle, Move, Swap and Remove Track commands #139

Merged
merged 5 commits into from
Oct 23, 2021

Conversation

samdammers
Copy link
Contributor

@samdammers samdammers commented Oct 23, 2021

These commands manipulate the queue.

Shuffle: shuffles the queue and displays the shuffled result
Move: moves a single track to the desired position
Swap: switched the places of two tracks
Remove: removes a track from the queue

@samdammers samdammers changed the title Add Move, Swap and Remove Track commands Add Shuffle, Move, Swap and Remove Track commands Oct 23, 2021
Copy link
Owner

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great contribution. I just tried out all the new commands and they work great, but I ran into a minor index issue with the swap commands where it swaps one index higher than what is entered (e.g. it swaps 4 and 5 when entering 3 and 4 as the input).

@samdammers
Copy link
Contributor Author

Hmm 🤔 thanks I'll take another look.

@samdammers
Copy link
Contributor Author

Ah got it, messed up the user option capture when I did some renaming

Copy link
Owner

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TannerGabriel TannerGabriel merged commit e4ed01a into TannerGabriel:master Oct 23, 2021
@TannerGabriel
Copy link
Owner

@samdammers Thank you again for your contribution.

@samdammers samdammers deleted the track-commands branch July 11, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants