This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
Allow configuration of ASG termination policies #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atayarani
force-pushed
the
refactor_elb_code
branch
from
df0ccc3
to
34711a2
Compare
|
Makes sense, but failing specs |
|
@StabbyCutyou specs are fixed |
|
@StabbyCutyou @marcuswalser @ehealy Accidentally made this PR bigger, but WONTFIX. New notes:
|
|
|
||
| config.merge!(aws_env.merge(user_data: Base64.encode64("#{user_data}"))) | ||
| Tapjoy::AutoscalingBootstrap::Audit.new(config) | ||
| when 'scale' |
There was a problem hiding this comment.
We'd discussed potentially having min/max stored in the yaml file. Desired probably ought to remain a CLI option - maybe include the ability to do it either way?
|
This is LGTM, we can address the min/max stuff in a followup PR. |
atayarani
added a commit
that referenced
this pull request
Oct 14, 2015
Allow configuration of ASG termination policies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tapjoy/eng-group-ops @StabbyCutyou
This allows more flexibility around which instances get scaled out.