This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
Make TASS use SDK for spot fleet requests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atayarani
force-pushed
the
feature/sdk_spot_fleets
branch
from
952ff3b
to
ce8d3f9
Compare
Merged
|
|
||
| # check the verison of the yaml we are reading, and do the new hotness if we are running v2 or higher | ||
| if newer_yaml_version?(config) | ||
| # Determine if we are making a cloudformation request | ||
| if config[:stack][:spot_fleet] |
There was a problem hiding this comment.
This is fine for he alpha, but this will break in the event we have things that aren't spot fleets that we stand up in new world tass
There was a problem hiding this comment.
Why would that be the case, if this only runs for spot fleets?
There was a problem hiding this comment.
Just thinking ahead under the assumption were going to want support things like asgs and launch configs outside the scope of being in a cf stack. Not something to worry about for the time being but we'll have to address it in the future.
|
This seems sane based on the current limitations of the Amazon api. LGTM. |
atayarani
added a commit
that referenced
this pull request
May 2, 2016
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 2, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 2, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 2, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 2, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 2, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 3, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 3, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 3, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 3, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 3, 2017
* Make TASS use SDK for spot fleet requests * fix specs
atayarani
added a commit
that referenced
this pull request
Oct 3, 2017
* Make TASS use SDK for spot fleet requests * fix specs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tapjoy/eng-group-ops
Notes:
TODO: