This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
Add spot pricing option to launch config #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,7 @@ | |||
| :vpc_subnets: # (String) Comma-separated list of VPC subnets to assign to autoscaler (valid for VPC instances only) | |||
| :classic_link_vpc_id: # (String) VPC id to use for ClassicLink (valid for EC2-Classic instances only) | |||
| :classic_link_sg_ids: # (String Array) VPC subnets to use for ClassicLink (valid for EC2-Classic instances only) | |||
| :spot_price: #(String) — The maximum hourly price to be paid for any Spot Instance launched to fulfill the request. (valid for spot instances only) | |||
There was a problem hiding this comment.
nitpick: space between # and (
|
visual inspection: looks good |
geoffreyclark
force-pushed
the
feature/spot_pricing
branch
from
e72a63b
to
aa35e5f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atayarani Tested by doing the following:
:spot_price: 0.1- result, no spot price (needed to be a string), all other settings look good.:spot_price: '0.1'- creates launch config with spot price of 0.1