Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Conanfile to package expected as a header-only library #56

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Modify Conanfile to package expected as a header-only library #56

merged 3 commits into from
Jul 8, 2019

Conversation

hannahwhy
Copy link
Contributor

Before describing the PR, I'd like to offer an alternative outcome for this PR: deletion of the Conanfile.

Since submitting the Conanfile, I've had some time to reflect on what C++ packaging ought to be like, and I'm coming around to Robert Schumacher's thesis on packaging, e.g. that libraries should be packageable but not packaged. In line with that, I'd be happy to maintain a conan-expected repository elsewhere.

That said, onto the PR:


Previously, the Conanfile had the package ID depend on settings like the
target architecture and compiler. expected's test executable depends on
this information, but the library itself does not.

This commit modifies the Conanfile as follows:

  • eliminates tests (not needed if we just want the library)
  • eliminates the influence of build settings on the package ID

Previously, the Conanfile had the package ID depend on settings like the
target architecture and compiler.  expected's test executable depends on
this information, but the library itself does not.

This commit modifies the Conanfile as follows:

- eliminates tests (not needed if we just want the library)
- eliminates the influence of build settings on the package ID
@TartanLlama
Copy link
Owner

I think having an external package sounds like a great idea and thanks very much for offering to maintain one. I'm currently redoing the CMake to make the library more in line with what people expect, so you might want to hold off until it's merged: #55

@hannahwhy
Copy link
Contributor Author

Sounds good 👍 I'll keep an eye on that PR.

@hannahwhy
Copy link
Contributor Author

Thanks for 1.0! 🎉

I've extracted the Conan recipe from this repository into https://github.com/yipdw/conan-tl-expected, and have updated it to use the CMake rules for build and packaging. I've also taken advantage of the 0.4 -> 1.0 major version bump to rename the Conan package from expected to tl-expected; please let me know if you'd like this changed.

I'm okay with resolving this PR by removing the Conan material from this repository, maybe also with adding a reference to the new Conan recipe for anyone who might be using it from this repo.

@TartanLlama
Copy link
Owner

Thank you!

@TartanLlama TartanLlama merged commit bcdc78b into TartanLlama:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants