Modify Conanfile to package expected as a header-only library #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before describing the PR, I'd like to offer an alternative outcome for this PR: deletion of the Conanfile.
Since submitting the Conanfile, I've had some time to reflect on what C++ packaging ought to be like, and I'm coming around to Robert Schumacher's thesis on packaging, e.g. that libraries should be packageable but not packaged. In line with that, I'd be happy to maintain a
conan-expected
repository elsewhere.That said, onto the PR:
Previously, the Conanfile had the package ID depend on settings like the
target architecture and compiler. expected's test executable depends on
this information, but the library itself does not.
This commit modifies the Conanfile as follows: