Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would suggest reverting the date format to yyyy-mm-dd on the activity_timeline. #2033

Open
ckjpn opened this issue Dec 9, 2019 · 9 comments
Labels
ui-strings Issue that requires changing the text of the UI.

Comments

@ckjpn
Copy link

ckjpn commented Dec 9, 2019

yyyy-mm-dd is much more internationally understood.

Perhaps this was an unintentional change.

Screen Shot 2019-12-09 at 9 00 52

@AndiPersti
Copy link
Contributor

AndiPersti commented Dec 9, 2019

Have you looked at the other language versions of that page? Do you want to revert the date format only for the English version or in general?

I have no problem reverting the date format. While working on that page I've tried different versions and also thought about whether to change the date format at all. But I would like to hear more opinions.

@jiru
Copy link
Member

jiru commented Dec 9, 2019

@AndiPersti I see no reason not to localize the date here.

@ckjpn Note that the date is now localized according to the interface language, thanks to AndiPersti’s recent localization efforts. So it shouldn’t be necessary to use a "more internationally understood" format any more.

That said, as for the English interface, the date format varies between regions. Since we don’t provide per-region locales, it might be better to use yyyy-mm-dd for English, if it is the most commonly understood format among English speaking countries.

@AndiPersti
Copy link
Contributor

A little background information:
The date/time formatting is based on the PHP class IntlDateFormatter which itself uses data from the Common Locale Data Repository (CLDR), a project by the Unicode Consortium. They define 4 formats: full, long, medium and short. (for how they are defined for English see https://www.unicode.org/cldr/charts/36/summary/en.html#1989).
I've mainly chosen the short format because it uses the least amount of space.

@trang
Copy link
Member

trang commented Dec 9, 2019

I would suggest medium format without the year.

Dec 1
Dec 2
Dec 3
etc

The year is already indicated in the title so there's no need to repeat it.

The month is also indicated in the title but having a number all alone might not be very explicit so it's okay to repeat it.

@Poulpisator
Copy link

I would suggest to use the day of the week. Currently, I don't find this page useful (personal opinion). However, looking at December 2019, for example, I saw that the 6th had much more contributions (more than 1,000 compared to the average) so I implied it was a Saturday or a Sunday. Looking at a calendar, I realized it was actually a Friday. So now, I'm curious...

Long story short, I personally think this page would provide more information if the day of the week was displayed

Sunday, December 1
Monday, December 2
Tuesday, December 3
etc

@AndiPersti
Copy link
Contributor

Here are some screenshots using the suggestions:
month_day
weekday_month_day_long

If we include the weekday, using abbreviations for weekday and month looks better IMHO:
weekday_month_day_short

@ckjpn
Copy link
Author

ckjpn commented Dec 13, 2019

I think that I like the 3rd one best, too. Perhaps the layout won't look as good once the dates go into 2 digits, but I'm not sure that that matter too much.

It might be nice if the most-recent were at the top, like it used to be years ago.

In other words, in reverse chronological order, so when visiting the page if would be easy to see the most recent days without needing to scroll down the page.

My guess is that if we could see the 2 or 3 most recent days on the upper right of the logged-in home page, that many regular contributors would find that very useful, and wouldn't need to keep coming to this page to find that information.

@trang
Copy link
Member

trang commented Dec 13, 2019

Let's go for option 3 then.

@trang trang modified the milestone: 2019-12-22 Dec 14, 2019
@trang trang added the ui-strings Issue that requires changing the text of the UI. label Dec 15, 2019
@jiru
Copy link
Member

jiru commented Mar 13, 2020

Well, bad news. It’s not possible to implement option 3 (as well as all the other suggested formats without a year) in a way that works with other languages than English because PHP doesn’t allow to use ICU pattern generators. The skeleton that we want for option 3 is MMMEd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-strings Issue that requires changing the text of the UI.
Projects
None yet
Development

No branches or pull requests

5 participants