Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Halpe26 keypoints. #25

Merged
merged 14 commits into from
Jul 3, 2024
Merged

Support Halpe26 keypoints. #25

merged 14 commits into from
Jul 3, 2024

Conversation

hunminkim98
Copy link
Contributor

@hunminkim98 hunminkim98 commented Jun 27, 2024

Dear @Tau-J.

Hello, first of all, thank you so much for your awesome work!
My name is Hunmin Kim and I'm interested in markerless motion capture and biomechanics.

I think Halpe26 keypoints are useful in the field of biomechanics.
So I wanted to implement something that supports Halpe26 in rtmlib, and here is the result!

I hope this works, and I hope you will consider this request.
Thank you.

Best regard.
HunMin Kim

@davidpagnon
Copy link
Contributor

Perfect timing @hunminkim98 ! (it almost looks like we work together :D ) -> Related to #24, which I am now closing.

Copy link
Owner

@Tau-J Tau-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your kind contribution! I have provided some suggestions on naming conventions. Please consider revising your PR to maintain stylistic consistency with the existing code in rtmlib.

rtmlib/tools/solution/body_and_feet.py Outdated Show resolved Hide resolved
@Tau-J
Copy link
Owner

Tau-J commented Jul 1, 2024

body+feet_demo.py should be renamed as body_with_feet_demo.py.

@hunminkim98
Copy link
Contributor Author

Hello,
I appreciate your consideration and suggestion!
I changed the names to fit your suggestions. I hope everything meets your expectations.

Copy link
Owner

@Tau-J Tau-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some links

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hunminkim98 and others added 2 commits July 3, 2024 13:56
Co-authored-by: Tau <taujiang@outlook.com>
Co-authored-by: Tau <taujiang@outlook.com>
Copy link
Owner

@Tau-J Tau-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tau-J Tau-J merged commit a9d8c5e into Tau-J:main Jul 3, 2024
@hunminkim98
Copy link
Contributor Author

Thanks for the approval and thanks again for your work🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants