Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: pass progress from plex when calling scrobble api #761

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Fix: pass progress from plex when calling scrobble api #761

merged 5 commits into from
Feb 3, 2022

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Jan 30, 2022 •
edited
Loading

Pass fresh progress value before calling stop/pause instead of previous value from update.

Probably fixes #758 and #766

This also improves logging, example:

2022-01-31 00:09:10,540 DEBUG[PlexTraktSync.WatchStateUpdater]:Scrobbled: {'id': 0, 'action': 'start', 'progress': 0.0, 'sharing': {'facebook': False, 'twitter': False, 'tumblr': False}, 'episode': {'season': 2, 'number': 4, ...
2022-01-31 00:09:16,294 DEBUG[PlexTraktSync.WatchStateUpdater]:Scrobbled: {'id': 0, 'action': 'pause', 'progress': 0.0, 'sharing': {'facebook': False, 'twitter': False, 'tumblr': False}, 'episode': {'season': 2, 'number': 4, ...

Requires:

Refs:

@glensc glensc added the docs needed Changes in this issue/pull request need to be documented label Jan 30, 2022
@glensc glensc self-assigned this Jan 30, 2022
This was referenced Jan 30, 2022
Open
Closed
@glensc glensc marked this pull request as ready for review February 3, 2022 21:01
@glensc glensc changed the title Feature: Print result of scrobble to debug log Fix: pass progress from plex when calling scrobble api Feb 3, 2022
@glensc glensc merged commit a7aac52 into Taxel:main Feb 3, 2022
@glensc glensc deleted the scrobble-response branch February 3, 2022 21:03
@glensc glensc mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
docs needed Changes in this issue/pull request need to be documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

watch doesn't add to history anymore
1 participant
@glensc