Update to work with kRPC server 0.2.x #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 0.2.2 (update TestServer.exe and specs accordingly)
|
Looks like the travis build failure is due to travis using an outdated version of bundler. The build works fine on my local machine with Ruby 2.1. |
|
Thanks, I really appreciate the time you took to patch it. |
TeWu
added a commit
that referenced
this pull request
Feb 15, 2016
Update to work with kRPC server 0.2.x
|
My pleasure - I'd not written in Ruby before and it was fun to learn it. I hope my code isn't too n00bish! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kRPC 0.2.x the server has been upgraded to use protobuf 3. This required some changes to the protocol buffer definitions (optional fields are no longer possible, so some boolean fields were added): krpc/krpc@92494c7#diff-4ea62fc6fe7db6b41cbca425cd4b0799
This patch updates the ruby client so that it works with server version 0.2.x. I also added some tests for the low level protobuf encoding, and updated it to use the official google-protobuf 3.0.0 gem.