Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#286) SPI 구조 변경 #297

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • 기존 Domain에 있던 SPI를 Application으로 이동

주요 변경 사항

  • VO 패키지 위치 변경
  • Domain Service에서 사용되는 SPI는 Domain 따로 만든다.

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Jan 9, 2023
@khcho0125 khcho0125 self-assigned this Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #297 (21bdf25) into develop (56a3336) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #297   +/-   ##
==========================================
  Coverage      37.70%   37.70%           
  Complexity       353      353           
==========================================
  Files            236      236           
  Lines           2854     2854           
  Branches         101      101           
==========================================
  Hits            1076     1076           
  Misses          1775     1775           
  Partials           3        3           
Impacted Files Coverage Δ
...mit/simtong/domain/schedule/spi/vo/SpotSchedule.kt 100.00% <ø> (ø)
...imtong/persistence/holiday/vo/EmployeeHolidayVO.kt 0.00% <ø> (ø)
...persistence/schedule/SchedulePersistenceAdapter.kt 0.00% <ø> (ø)
.../simtong/persistence/schedule/vo/SpotScheduleVo.kt 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a3336...21bdf25. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@khcho0125 khcho0125 merged commit 4cab708 into develop Jan 10, 2023
@khcho0125 khcho0125 deleted the refactor/286-change-spi-structure branch January 10, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants