-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chat Messages to DBLog Plugin #272
base: master
Are you sure you want to change the base?
Conversation
Add chat message table to DBLog Schema includes: Server match Time Chat(teamchat/squadchat) message steamid I did not create a foreign key dependence on steamuser, as I had issues when we received a chat message but had not received and created the steamuser via PLAYER_CONNECTED.
@ect0s has then been checked to make sure the tables are created properly in the DB? |
Yes, though I did just update the Schema.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good, unable to test internally on my end.
I've had this running for 4 days so far, no issues. I've also deleted and recreated the DB multiple times, so as long as the SquadJS user people have configured in their DB can create the table, this should be good to merge. |
@ect0s could you add the team id and squad id of the player too? |
Sure. Would team faction maybe matter here as well? Or the Squads Name at the time? Just if I'm going to open and edit this PR, I'd like to nail down everything at once |
The name of the squad could be useful, because it can change if a squad gets opened and closed. |
Team: Teamid SquadID: SquadID SquadName: SquadName
@reck1610 Implemented. Will require an alter to the table if you've already taken these changes.
|
Someone have the |
The ALTER command is not needed because the changes add a new table, but won't modify the previously existing tables and the foreign keys are automatically updated by sequelize calling the .sync() method. In case we really want to make sure, we can replace .sync() with .sync({ alter: true }) Also, I have another modification of this DBLog plugin to include tickets and some more details about the teams. Everything get stored at the end of each match.
|
Add chat message table to DBLog
Schema includes:
Server
match
Time
Chat(teamchat/squadchat)
message
steamid
I did not create a foreign key dependence on steamuser, as I had issues when we received a chat message but had not received and created the steamuser via PLAYER_CONNECTED.