[FEAT] 테마 리스트 별 루틴 리스트 조회 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
지켜보고 있다.. 화이팅! |
csb9427
approved these changes
Jan 9, 2024
Comment on lines
-9
to
+10
| SUCCESS_GET_THEMES("테마 조회 성공"), | ||
| SUCCESS_GET_THEME("데일리 루틴 테마 조회 성공"), | ||
| SUCCESS_GET_ROUTINE("데일리 루틴 조회 성공"), |
There was a problem hiding this comment.
우선은 각 폴더별로 ResponseMessage 이거 두고 좀 나중에는 이런 공통 메시지는 합칠까요? 어떻게 생각하시나요
Comment on lines
+32
to
+42
| @MockBean | ||
| DailyRoutineController controller; | ||
|
|
||
| private final String DEFAULT_URL = "/api/v1/routines/daily"; | ||
| private final String TAG = "DAILY ROUTINE"; | ||
|
|
||
| @Test | ||
| @DisplayName("데일리 루틴 테마 리스트 조회 성공") | ||
| void success_getDailyThemes() throws Exception { | ||
| // given | ||
| DailyThemesResponse themes = DailyRoutineFixture.createDailyThemesResponseDTO(); |
There was a problem hiding this comment.
테스트 코드까지 작성하는 거 진짜 개멋있다.. 리스펙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항