[FEAT] 테마 별 데일리 루틴 리스트 조회 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chan531
approved these changes
Jan 9, 2024
|
|
||
| private DailyTheme getTheme(Long id) { | ||
| return dailyThemeRepository.findById(id) | ||
| .orElseThrow(() -> new EntityNotFoundException(INVALID_THEME.getMessage())); |
There was a problem hiding this comment.
세미나에서는 repository에서 에러를 던지는 코드로 배웠는데 두 방법 중 service에서 에러를 던지는 코드로 작성하신 이유가 혹시 있다면 궁금합니다!
There was a problem hiding this comment.
좋은 질문입니다. 구두 회의로 의논 나눴으니 넘어가도록 하겠습니다!
There was a problem hiding this comment.
@csb9427 찬이와 구두로 논의했는데, Repository에서 예외를 던지면 데이터가 존재하지 않을 경우의 추가적인 처리가 한정적이라고 생각해서 서비스 예외 처리로 판단했어요. 서비스에서 Optional로 받아오면 데이터가 비어있을 때의 추가 처리가 좀 더 확장적으로 이루어질 수 있다고 생각합니다.
csb9427
approved these changes
Jan 9, 2024
| @@ -22,6 +22,7 @@ public List<DailyRoutine> findAllByThemes(List<Long> themeIds) { | |||
| return queryFactory | |||
| .selectFrom(dailyRoutine) | |||
| .where(dailyRoutine.theme.id.in(themeIds)) | |||
| .orderBy(dailyRoutine.content.asc()) | |||
There was a problem hiding this comment.
@csb9427 생략하면 컴파일 오류가 뜨더라구요 😅
|
|
||
| private DailyTheme getTheme(Long id) { | ||
| return dailyThemeRepository.findById(id) | ||
| .orElseThrow(() -> new EntityNotFoundException(INVALID_THEME.getMessage())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항