Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 홈 화면 api #85

Merged
merged 9 commits into from
Jan 12, 2024
Merged

[FEAT] 홈 화면 api #85

merged 9 commits into from
Jan 12, 2024

Conversation

Chan531
Copy link
Contributor

@Chan531 Chan531 commented Jan 12, 2024

✨ Related Issue

📝 기능 구현 명세

image

  • 포스트맨 결과
    image
  • 로컬 스웨거

🐥 추가적인 언급 사항

  • of 메서드에 필요한 정보만을 줄려다보니 꽤나 복잡해졌는데 한 번 봐주시면 감사하겠습니다.

@Chan531 Chan531 added chan 찬 작업 feat 기능 개발 test 테스트 labels Jan 12, 2024
@Chan531 Chan531 self-assigned this Jan 12, 2024
csb9427
csb9427 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

thguss
thguss reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!
approve 전에 몇 가지 리뷰에 대해서 함께 논의하면 좋을 것 같아요 :)

src/main/java/com/soptie/server/member/controller/MemberController.java Outdated Show resolved Hide resolved
src/main/java/com/soptie/server/member/dto/MemberHomeScreenResponse.java Outdated Show resolved Hide resolved
src/main/java/com/soptie/server/member/dto/MemberHomeScreenResponse.java Outdated Show resolved Hide resolved
src/main/java/com/soptie/server/member/service/MemberServiceImpl.java Outdated Show resolved Hide resolved
thguss
thguss reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

거의 다 왔다!

src/main/java/com/soptie/server/member/controller/MemberController.java Outdated Show resolved Hide resolved
src/main/java/com/soptie/server/member/service/MemberServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/com/soptie/server/member/message/ResponseMessage.java Outdated Show resolved Hide resolved
src/main/java/com/soptie/server/member/service/MemberService.java Outdated Show resolved Hide resolved
thguss
thguss approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@Chan531 Chan531 merged commit 8c91d67 into develop Jan 12, 2024
1 check passed
@Chan531 Chan531 deleted the feature/#77-home-page-api branch January 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csb9427 csb9427 csb9427 approved these changes

@thguss thguss thguss approved these changes

Assignees

@Chan531 Chan531

Labels
chan 찬 작업 feat 기능 개발 test 테스트
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 홈 화면 api
3 participants
@Chan531 @thguss @csb9427