Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

헤더 알림 뱃지 구현 #222

Merged
merged 5 commits into from
Dec 2, 2023
Merged

헤더 알림 뱃지 구현 #222

merged 5 commits into from
Dec 2, 2023

Conversation

eeseung
Copy link
Member

@eeseung eeseung commented Dec 1, 2023

📑 이슈 번호

🚧 구현 내용

  • 헤더 알림 뱃지를 구현했습니다.
    • 9개 초과 시 9+로 표시됩니다.
    • 카운트를 보여주면 좋을 것 같아 아래와 같이 구현했습니다. 다른 의견 있으면 남겨주세요!
  • 검색 아이콘을 수정했습니다.
LinkHub-FE_header-notification-badge_01 LinkHub-FE_header-notification-badge_02

🚨 특이 사항

Header 컴포넌트

  • 로직 관련된 코드를 useHeader 커스텀 훅으로 분리했습니다.

@eeseung eeseung added the ✨ Feature 기능 개발 label Dec 1, 2023
@eeseung eeseung added this to the 4차 스프린트 milestone Dec 1, 2023
@eeseung eeseung self-assigned this Dec 1, 2023
@eeseung eeseung linked an issue Dec 1, 2023 that may be closed by this pull request
헤더 알림 뱃지 구현 #220
Closed
2 tasks
bomi8489
bomi8489 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@bomi8489 bomi8489 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!! 👍🏻👍🏻

dudwns
dudwns reviewed Dec 2, 2023
View reviewed changes
Copy link
Contributor

@dudwns dudwns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재는 초대 알림이 2개 존재하는데 서버에서는 unCheckedNotificationCount가 4개로 와지는 것같네요..?! 🤔

스크린샷 2023-12-02 오후 3 42 11

백엔드 분께 여쭤보니 탈퇴한 계정이 보낸 알람이 남아 있어서 그렇다고 하네요!
아직 서비스에 탈퇴 기능이 없어서 DB를 초기화 하면 상관 없는 이슈일 것 같네요. 😊

@eeseung eeseung merged commit a919ee7 into develop Dec 2, 2023
1 check passed
@eeseung eeseung deleted the feature/#220/header-notification-badge branch December 2, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudwns dudwns dudwns approved these changes

@bomi8489 bomi8489 bomi8489 approved these changes

Assignees

@eeseung eeseung

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
4차 스프린트
Development

Successfully merging this pull request may close these issues.

헤더 알림 뱃지 구현
3 participants
@eeseung @dudwns @bomi8489