Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (configurable) remote logging service #550

Open
DinisCruz opened this issue Mar 14, 2015 · 9 comments
Open

Add (configurable) remote logging service #550

DinisCruz opened this issue Mar 14, 2015 · 9 comments

Comments

@DinisCruz
Copy link
Contributor

While working on #536 I looked at a couple SaaS logging services and was able to quickly create a PoC for Loggly and LogEntries

They are really powerful and configurable, and I think we will get a lot out of it

Here is LogEntries 'live tail' view of all TM_Design log messages and some custom log actions that I added

image

the code for this will be on the Issue_550_Log_SaaS branch

DinisCruz added a commit that referenced this issue Mar 14, 2015
adding Logging SaaS PoC (see #550)
@DinisCruz
Copy link
Contributor Author

@roman87 and @michaelhidalgo, for you to see this in action, replace the token you will find here https://github.com/TeamMentor/TM_4_0_Design/blob/Issue_550_Log_SaaS/node/services/Logging-Service.coffee#L17 with one you create from a test account on https://logentries.com (note: the pushed version only has wired the integration with LogEntries (i.e. Loggly is not receiving data))

This is only capturing log files for TM_Design (I will add TM_GraphDB tomorrow)

You should also see a copy of all TM_Design logs (sent to LogEntries) on the .logs folder (with a file created every hour (this could be changed to every day or even every minute)

For reference the API used for logging is the https://github.com/winstonjs/winston which seems to be the most mature and recommended node logging api

@romichg
Copy link

romichg commented Mar 15, 2015

  1. you are missing winston-logentries as a module in package.json
  2. How do I turn this thing off? I assume commenting out https://github.com/TeamMentor/TM_4_0_Design/blob/Issue_550_Log_SaaS/node/services/Logging-Service.coffee#L27 should do this? This not something we need to spend our time on. I am not comfortable sending our logs to 3d parties without doing proper analysis of what is sent, how it is stored etc. Logs are sensitive and should be handled with care.
  3. Can we please turn this off, take the code out, and only log to file. Then we can move this issue to Sprint 3, as a low priority, where we can appropriately address it with proper discussion.

@romichg romichg changed the title Add (configurable) remote logging service Remvoe [was: Add] (configurable) remote logging service Mar 15, 2015
@romichg romichg changed the title Remvoe [was: Add] (configurable) remote logging service Remove [was: Add] (configurable) remote logging service Mar 15, 2015
DinisCruz added a commit that referenced this issue Mar 16, 2015
@DinisCruz
Copy link
Contributor Author

  1. yeah, sorry I missed that mapping in package.json
  2. yes if you comment out that line that will not work. I was thinking that the place to put the 'on/off' switch would be the .tm.config.json file, (in terms of mapping what should go in there, I opened Identify which types of data need to be removed from logs #553 so that we can identify it)
  3. no need to turn it off, at the moment this is on a branch and it can stay in there until we decide to implement it

@romichg
Copy link

romichg commented Mar 16, 2015

  1. cool
  2. yea .tm.config.json should be a good place (for both TMDesign and GraphDB).
  3. But we should merge the local logging into the master branch, so we have logs. That is why we need to to turn off the remote logging until we figure Identify which types of data need to be removed from logs #553 out.

@DinisCruz
Copy link
Contributor Author

as you can see on #536 the local logging is already on both master repos (dev and graphDb)

@romichg
Copy link

romichg commented Mar 16, 2015

What about remote logging, is it off by default :)?

@DinisCruz
Copy link
Contributor Author

The code is not there, it is only on the branch

@romichg
Copy link

romichg commented Mar 19, 2015

Changing the priority to be on par with related issue: #553

@romichg romichg changed the title Remove [was: Add] (configurable) remote logging service Add (configurable) remote logging service Mar 19, 2015
@romichg
Copy link

romichg commented Aug 14, 2015

Moving to backlog since there is no requirement for this at the moment.

@romichg romichg added P3 and removed P2 labels Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants