Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set color of Navigation bar in the bottom #1494

Closed
2 tasks done
RocketJannis opened this issue Jun 17, 2018 · 5 comments · Fixed by #2569
Closed
2 tasks done

Set color of Navigation bar in the bottom #1494

RocketJannis opened this issue Jun 17, 2018 · 5 comments · Fixed by #2569
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@RocketJannis
Copy link

RocketJannis commented Jun 17, 2018

My Samsung A8 has got a white bottom navigation bar (this one with back, home and multitab) and its not very nice next to the dark theme of NewPipe

Just set it to black or something like that

Thank you for this software

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.
@theScrabi
Copy link
Member

I see. Well help is always welcome :)

@SpajicM
Copy link
Contributor

SpajicM commented Jun 24, 2018

Looked into this for a minute, and seems it can only be correctly handled in Android 8.1+.

While background of navigation bar can be changed (since Lollipop), the color of buttons can only be changed since 8.1 Oreo. If navigation bar is set to black in older versions, you'll get black buttons on black background.

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@TobiGr TobiGr removed the stale label Jul 19, 2019
@marcovr
Copy link
Contributor

marcovr commented Aug 18, 2019

I agree, having a white navigation bar doesn't look very nice, especially with the black theme.

Looked into this for a minute, and seems it can only be correctly handled in Android 8.1+.

Then how about applying the color change only for 8.1+ ? For example by having a file styles.xml in the res/values-v27 folder with the following content:

<?xml version="1.0" encoding="utf-8"?>
<resources>

    <style name="BlackTheme" parent="DarkTheme">
        <item name="android:windowBackground">@color/black_background_color</item>
        <item name="windowBackground">@color/black_background_color</item>
        <item name="android:navigationBarColor">@android:color/black</item>
        <item name="android:windowLightNavigationBar">false</item>

        <item name="separator_color">@color/black_separator_color</item>
        <item name="contrast_background_color">@color/black_contrast_background_color</item>
    </style>
</resources>

I successfully tested this on Emulators running Android 7 and 9 as well as on a Samsung phone running Android 9. Here two screenshots from the phone (before and after the change):

Now of course this only changes the color for the black theme, but the same could also be done for the dark theme.

@Stypox
Copy link
Member

Stypox commented Aug 27, 2019

@marcovr open a pull request :-D

@Stypox Stypox added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Aug 27, 2019
marcovr added a commit to marcovr/NewPipe that referenced this issue Aug 27, 2019
marcovr added a commit to marcovr/NewPipe that referenced this issue Oct 15, 2019
marcovr added a commit to marcovr/NewPipe that referenced this issue Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants