Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display comment replies #2277

Closed
BaumGuard opened this issue Apr 9, 2019 · 51 comments · Fixed by #10018
Closed

Display comment replies #2277

BaumGuard opened this issue Apr 9, 2019 · 51 comments · Fixed by #10018
Labels
feature request Issue is related to a feature in the app multiservice Issues related to multiple services

Comments

@BaumGuard
Copy link

It's great that NewPipe has the feature to view comments since the version 0.16.0! But I miss a function to view the answers of the comments.

@hp8wvvvgnj6asjm7
Copy link

Anyone working on this?

@lu4p
Copy link

lu4p commented Sep 23, 2019

Would appreciate this feature as I often open YouTube in Firefox just to read the comments.

@Gymcap
Copy link

Gymcap commented Sep 23, 2019

Maybe have the comment answers collapsed by default to keep from taking up too much space. You could tap a down arrow to reveal the comment answers. This could result in showing 5-10 answers with a "show more" at the bottom of the comment thread.

@Stypox Stypox added feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor labels Sep 27, 2019
@chekmanh
Copy link

I think this is a really nice feature, would really appreciate it

@alittlebitofit
Copy link

By "answers of comments", does it mean replies to comments as in a comment thread?

If yes, then yes I want this feature too.

Is there any update on this feature?

@opusforlife2
Copy link
Collaborator

Yup. That's what it means. Which means one less issue for you to open. :P

@alittlebitofit
Copy link

Haha yea :P

So any update?

@opusforlife2
Copy link
Collaborator

Nyope.

@alittlebitofit
Copy link

Ah well, atleast 33.33333% of my issues are solved.

@Invisible3ck
Copy link

I’d like this feature, too. Hopefully it gets added one day.

@ghost
Copy link

ghost commented Dec 25, 2020

I’d like this feature, too. Hopefully it gets added one day.

If the creators of newpipe are waiting for someone to implement it, I believe we will not see this feature until 2050.

@NewNewPipe
Copy link

NewNewPipe commented Dec 27, 2020

Hello.

With the help of mhmdanas I would like to add what I miss the most in NewPipe nowadays.

The functionality / ability to SAVE all the comments under the movie together with the answers (tree structure) to TXT, HTML, PDF file would be very useful.

Thanks.

@Kohoshi12
Copy link

Freetube implemented this feature.

@0rdinant
Copy link

I am also interested in this feature, including timestamps.

@Gottarocket
Copy link

+1 for this

@ShareASmile
Copy link
Collaborator

ShareASmile commented Jul 9, 2021

This feature is being worked upon in this New PR on the extractor side:
Edit: New PR Link:-
TeamNewPipe/NewPipeExtractor#703

@TiA4f8R this issue should be linked to the Comments-Reply PR to auto close.

@krlvm
Copy link
Contributor

krlvm commented Jul 14, 2022

@AudricV @Stypox What's your opinion on using bottom sheet to display replies?

@Stypox
Copy link
Member

Stypox commented Jul 14, 2022

Do you mean, something that slides in from the bottom, and that the user is able to close by swiping down from the top bar?

@krlvm
Copy link
Contributor

krlvm commented Jul 14, 2022

Do you mean, something that slides in from the bottom, and that the user is able to close by swiping down from the top bar?

Yes. Some other UI elements can also be replaced with this as part of UI refresh.

@xz-dev
Copy link

xz-dev commented Sep 22, 2022

@AudricV I really like that design and was also what I was thinking about. Once the extractor has a stable API for comment replies access, including replies, I can work on the UI or we could have a call.

Such a design like PeerTube would look ugly on newpipe at this stage, because the player position is not fixed on top, also, it need a lot of code and test.
So I'm going to implement it the way youtube shows it and RP it.
What do you think?

@ygz213

This comment was marked as spam.

@opusforlife2

This comment was marked as resolved.

@ygz213

This comment was marked as off-topic.

@xz-dev
Copy link

xz-dev commented Sep 23, 2022

@ygz213 You're most welcome to open a PR.

Hi, If you think it's time to program right now, I will progam it next days and PR it.
I just not sure it's there anyone coding for it now.

@opusforlife2
Copy link
Collaborator

@xz-dev No one else is coding this. A PR is most welcome. But you're waiting on @AudricV's answer, aren't you?

@xz-dev
Copy link

xz-dev commented Sep 23, 2022

@xz-dev No one else is coding this. A PR is most welcome. But you're waiting on @AudricV's answer, aren't you?

Because I see that he has something special mind, but I may not be available after a few days, so I'll start now.

@Mhowser

This comment was marked as duplicate.

@AudricV
Copy link
Member

AudricV commented Sep 23, 2022

@xz-dev Hmm, I don't understand the problems you raised.

Such a design like PeerTube would look ugly on newpipe at this stage

What is really the difference of PeerTube's comment's UI with the one of YouTube? For me they are using the same UI principles, except the fact there is not only one replies level on PeerTube.

the player position is not fixed on top

I don't see a link with the player and comment replies. What does the player have to do with comments and/or their replies?

it need a lot of code and test

Yes, even if it seems to be a small feature for users, it requires a lot of changes in the codebase for it. Don't be discouraged by this!

@xz-dev
Copy link

xz-dev commented Sep 24, 2022

@xz-dev Hmm, I don't understand the problems you raised.

Such a design like PeerTube would look ugly on newpipe at this stage

What is really the difference of PeerTube's comment's UI with the one of YouTube? For me they are using the same UI principles, except the fact there is not only one replies level on PeerTube.

the player position is not fixed on top

I don't see a link with the player and comment replies. What does the player have to do with comments and/or their replies?

it need a lot of code and test

Yes, even if it seems to be a small feature for users, it requires a lot of changes in the codebase for it. Don't be discouraged by this!

The main idea I'm trying to convey is that I often view comments while watching a video, and by default the video is slid off the screen, so I usually enable the video popup.
So, like AudricV showing, full screen display comment like that would completely cover the video, or the comment section would be covered by the hovered video popup window.
So, I'll follow #7244 and patch on it.

@AudricV
Copy link
Member

AudricV commented Sep 24, 2022

The main idea I'm trying to convey is that I often view comments while watching a video, and by default the video is slid off the screen, so I usually enable the video popup.

You don't have to care with the feature of showing player while showing one of the content tabs (description + metadata, comments, related items). This is a separate feature request, and from a code perspective, comments and video are separated.

If the player is made sticky at some point, it should not change the comments UI except the height used for comments, that's it.

So, like AudricV showing, full screen display comment like that would completely cover the video, or the comment section would be covered by the hovered video popup window.

My UI concept talks about the comments UI but it doesn't talk about the VideoDetailFragment itself.

So, I'll follow #7244 and patch on it.

Free feel to do so but this model has some issues in the future, requiring at least that you fix them. However, in my opinion, the UI I presented seems to be more readable for users.

@xz-dev
Copy link

xz-dev commented Sep 24, 2022

Free feel to do so but this model has some issues in the future, requiring at least that you fix them. However, in my opinion, the UI I presented seems to be more readable for users.

Fine, I'll try to let it like that, in order to not have waterfall issues.
Screenshot_20220924-221725_YouTube

@AudricV
Copy link
Member

AudricV commented Sep 24, 2022

That's from where my idea comes from! Thank you :)

@xz-dev xz-dev mentioned this issue Sep 25, 2022
5 tasks
@xz-dev
Copy link

xz-dev commented Sep 25, 2022

I'm done, I cann't wait seeing merged.

@litetex
Copy link
Member

litetex commented Mar 3, 2023

Just my 5 cents on this topic regarding comments.

The Infinity for Reddit app already has nested comments implemented:
grafik

Maybe some code from them could be reused (however be careful with the license) or inspiration taken from.

@JacksonChen666
Copy link

The Infinity for Reddit app already has nested comments implemented:

image

Maybe some code from them could be reused (however be careful with the license) or inspiration taken from.

seems to be already planned (kind of)

@Gottarocket
Copy link

@litetex Libretube has comment replies. They use newpipe extractor so some code can be similar and be used

@AudricV
Copy link
Member

AudricV commented Mar 4, 2023

They don't use the extractor directly, they use Piped's API, which is based on the extractor.

But some code can be reused indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app multiservice Issues related to multiple services
Projects
None yet