Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported URL from Google Search results and/or Google video search #3790

Closed
webber-naut opened this issue Jun 18, 2020 · 7 comments · Fixed by TeamNewPipe/NewPipeExtractor#362
Labels
bug Issue is related to a bug

Comments

@webber-naut
Copy link

Version

0.19.5

Steps to reproduce the bug

Google anything that returns youtube video. Also you can choose video tab for video search only.
Click to share to newpipe returns error. Unsupported URL.

URL scheme is: https://www.google.com/url?paramaters&url=https://m.youtube.com/watch....

Expected behavior

Play video with newpipe

Actual behavior

Returns Unsupported URL error at bottom of screen. Needs to parse the link to get url parameter.

@webber-naut webber-naut added the bug Issue is related to a bug label Jun 18, 2020
@Stypox
Copy link
Member

Stypox commented Jun 27, 2020

Could you provide a full link?

@Stypox
Copy link
Member

Stypox commented Jun 27, 2020

@B0pol
Copy link
Member

B0pol commented Jun 27, 2020

Uh, google has google.com .fr .it .co.uk .es… all regional TLD, moreover it would say open NewPipe and say unsupported URL for every non-youtube google links

@Stypox
Copy link
Member

Stypox commented Jun 27, 2020

@B0pol I'm currently implementing this for every service, with a utility function called in LinkHandlerFactory.fromUrl and all of its overriders

@B0pol
Copy link
Member

B0pol commented Jun 27, 2020

What about calling openUrlInBrowser on unsupported URL? It would make sense, wouldn't it?

@Stypox
Copy link
Member

Stypox commented Jun 27, 2020

It would be confusing imo: if I shared something to NewPipe, I don't expect a browser to be opened

@B0pol
Copy link
Member

B0pol commented Jun 27, 2020

true. what about a prompt: This URL is unsupported, would you want to open it in your browser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants