Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to not colorize notification #4643

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Add option to not colorize notification #4643

merged 1 commit into from
Nov 1, 2020

Conversation

XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented Oct 25, 2020 •
edited
Loading

What is it?

  • Feature (user facing)

Description of the changes in your PR

  • Add option to not colorize notifications
  • Setting is located under notifcation

Fixes the following issue(s)

APK testing

updated after rebase
app-debug.zip

Due diligence

Stypox
Stypox requested changes Oct 25, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, thank you for taking care of this!

app/src/main/res/values/settings_keys.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/player/NotificationUtil.java Outdated Show resolved Hide resolved
@XiangRongLin XiangRongLin mentioned this pull request Oct 25, 2020
Closed
@Stypox
Copy link
Member

Stypox commented Oct 25, 2020

Please move the setting above the action buttons configuration, below scale thumbnail, and also hide it in case the user is on API <21. In order to hide multiple views at a time you can use a Group

@XiangRongLin
Copy link
Collaborator Author

I'll adjust the PR when #4652 gets merged

@XiangRongLin XiangRongLin force-pushed the colorize_notification branch 2 times, most recently from 4ecff0e to 47182d9 Compare November 1, 2020 17:13
@XiangRongLin
Copy link
Collaborator Author

@Stypox I rebased it onto my PR and added the API level check

@XiangRongLin XiangRongLin mentioned this pull request Nov 1, 2020
Merged
2 tasks
Stypox
Stypox reviewed Nov 1, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on 4.4, 7.0 and 10 and it worked as expected. Thank you!

Btw, if you noticed I force-pushed your branch in order to remove the .setColor(ContextCompat.getColor(player.context, R.color.gray)) you forgot to remove ;-)

@Stypox Stypox merged commit 4c77e5c into TeamNewPipe:dev Nov 1, 2020
@XiangRongLin XiangRongLin deleted the colorize_notification branch November 2, 2020 06:01
This was referenced Nov 10, 2020
Closed
Merged
@B0pol B0pol mentioned this pull request Nov 19, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to disable notification color adjustment to video thumbnail
2 participants
@XiangRongLin @Stypox