Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include installation methods other than F-Droid #5108

Merged
merged 6 commits into from Jan 15, 2021

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Dec 6, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Rename "updates" section to "installation"
  • Add a hidden span with ID #updates so as not to break old links
  • Update "installation" section to account for F-Droid bug
  • (Temporarily) remove the F-Droid badge

@B0pol suggested that we get somebody to design a NewPipe-y version of the F-Droid badge. Until then, I think we should remove the badge altogether.

@B0pol what do you think I should do exactly?

Fixes the following issue(s)

APK testing

Unnecessary.

Due diligence

Pun not intended (oh really?).
@kujaw
Copy link

kujaw commented Jan 3, 2021

Isn't installing NewPipe Legacy also one of temporary solutions?
I've just installed it and it works. Additionally I don't have to install any repo or download apk from the website.

@Stypox
Copy link
Member

Stypox commented Jan 14, 2021

@mhmdanas is this ready?

@triallax
Copy link
Contributor Author

@Stypox no. I totally forgot about this PR. I'll finish it tomorrow.

@triallax
Copy link
Contributor Author

Done. You can review now.

@triallax triallax marked this pull request as ready for review January 15, 2021 15:28
@triallax triallax requested a review from B0pol January 15, 2021 15:28
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, thank you for looking into it
When will F-Droid solve the issue?!?!?

README.md Outdated Show resolved Hide resolved
@TobiGr TobiGr self-requested a review January 15, 2021 19:43
@Stypox Stypox merged commit 54cb26f into TeamNewPipe:dev Jan 15, 2021
@TobiGr
Copy link
Member

TobiGr commented Jan 15, 2021

We need a list of README translators, so we can ping them when changing the English version and the changes can be applied to the other READMEs as fast as possible.

@Stypox
Copy link
Member

Stypox commented Jan 15, 2021

Can't READMEs be pushed to Weblate?

This was referenced Jan 18, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 20, 2021
…me-installation-section

Update README.md to include installation methods other than F-Droid
@triallax triallax deleted the update-readme-installation-section branch June 6, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README.md to include other ways to install
4 participants