Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove APK testing section from PR template #5284

Merged

Conversation

triallax
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Removed the APK testing section from the PR template because debug APKs are built by the automatically-run workflows now.

APK testing

-_-

Due diligence

This is because the our workflows build debug APKs now.
@FireMasterK
Copy link
Member

We still need to complete the action. (Posting the comment with a direct link)

@XiangRongLin
Copy link
Collaborator

I agree that it can't be completly removed yet. For now it can tell the contributor to copy the URL to the specific CI job where the apk can be downloaded.

Also the information that the branch name is used as suffix in the app ID would need to be moved somewhere else. Otherwise that information gets lost. Contribution guidelines would be possible.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge this

@Stypox Stypox merged commit 0d33f8b into TeamNewPipe:dev Jan 16, 2021
This was referenced Jan 18, 2021
@triallax triallax deleted the remove-pr-template-testing-apk-section branch March 24, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants