add list item to play video on kodi #5310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangRongLin
requested changes
Dec 30, 2020
app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java
Outdated
Show resolved
Hide resolved
Stypox
requested changes
Dec 30, 2020
app/src/main/java/org/schabi/newpipe/util/StreamDialogEntry.java
Outdated
Show resolved
Hide resolved
|
i've resolved all inline feedback. i'm afraid i'm not able to contribute instrumentation and test harness at this time. |
XiangRongLin
previously approved these changes
Dec 31, 2020
|
thank you, @XiangRongLin! i believe i accidentally put @Stypox in the critical path as well, so it looks like i'll just need one more review from them before merging. thank you all for this amazing project. |
Stypox
requested changes
Jan 1, 2021
|
resolved remaining feedback in latest commit. please take another look. |
|
@Stypox thank you, are you able to approve? it seems merge is blocked on your approval and i'm not able to remove you. |
TobiGr
approved these changes
Jan 2, 2021
|
@Stypox -- friendly ping |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows the user to long press on a video in any list (search, history, playlist, etc) and send it directly to Kodi. this change honors the existing
Show "Play with Kodi" optionsetting and only displays on streams supported by Kore.there is opportunity to reduce duplication in this part of the code base generally.
closes: #5157
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
app-debug.zip
Due diligence