Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Somali language name #5376

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Fixes Somali language name #5376

merged 1 commit into from
Jan 9, 2021

Conversation

nadiration
Copy link
Contributor

@nadiration nadiration commented Jan 9, 2021

Changed the Somali language name from Af-Soomaali to Soomaali which is common and more user friendly when users are looking for Somali language in the list (since they aren't expecting it starts with A as in Af-Soomaali).
I contributed the language to the project on Weblate and I think this is name is better.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)
  • Spelling fix (user facing)

Description of the changes in your PR

  • Changes the Somali language name to the common one which is Soomaali from Af-Soomaali

Fixes the following issue(s)

  • Users will be expecting Somali language to start with an S

APK testing

debug.zip

Due diligence

Changed the Somali language name from Af-Soomaali to Soomaali which is common and more user friendly when users are looking for Somali language in the list (since they aren't expecting it starts with A as in Af-Soomaali).
I contributed the language to the project on Weblate and I think this is name is better.
@nadiration nadiration changed the title Update settings_keys.xml Fixes Somali language name Jan 9, 2021
@nadiration nadiration changed the title Fixes Somali language name [localization] Fixes Somali language name Jan 9, 2021
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TobiGr TobiGr added the localisation / translation Everything that has to do with translations or Weblate label Jan 9, 2021
@TobiGr TobiGr merged commit 114806d into TeamNewPipe:dev Jan 9, 2021
@nadiration nadiration changed the title [localization] Fixes Somali language name Fixes Somali language name Jan 12, 2021
This was referenced Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants