Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some random NullPointerExceptions #5944

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Mar 28, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

I got a random NullPointerException when clicking fast on the search button, this PR should prevent it, even though it should never happen.
While I was at it I also fixed two other random NPEs.

    java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.Object java.util.Map.get(java.lang.Object)' on a null object reference
        at org.schabi.newpipe.fragments.list.search.SearchFragment.onOptionsItemSelected(SearchFragment.java:460)
        at androidx.fragment.app.Fragment.performOptionsItemSelected(Fragment.java:2830)
        ...

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@triallax triallax added the bug Issue is related to a bug label Mar 29, 2021
@Stypox
Copy link
Member Author

Stypox commented Mar 31, 2021

@XiangRongLin done

@Stypox Stypox merged commit 43f8540 into TeamNewPipe:dev Mar 31, 2021
This was referenced Apr 11, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
@Stypox Stypox deleted the fix-search-menu branch August 4, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
3 participants