Fix trying to delete object not in list

[sauravrao637]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

-When the removeItem() is called it might happen somehow that object is not in list , in this case indexOf() will return -1 and in this case we should not try to delete object by it's index (i.e is -1)
-Coming to "somehow" this may happen when
1)the removeItem() is called on duplicate of item in list , in this case we need to implement a way to remove item by it's duplicate as duplicate is not in list
2)the object is already deleted and the UI is not updated (handled this in this PR)

Fixes the following issue(s)

• Fixes Crashing When Deleting From Playlist Tab #3891

Relies on the following changes

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

• I read the contribution guidelines.

[TobiGr]

Thank you.

[sauravrao637]

@Redirion See it shows "Failing after 49s - build-and-test-jvm"

[Redirion]

ah found the reason. Please modify the checkstyle-suppressions.xml

it contains: <suppress checks="FinalParameters" files="LocalItemListAdapter.java" lines="221,293"/>

the line numbers need to be adjusted accordingly

[sauravrao637]

ah found the reason. Please modify the checkstyle-suppressions.xml

it contains: <suppress checks="FinalParameters" files="LocalItemListAdapter.java" lines="221,293"/>

the line numbers need to be adjusted accordingly

What if in future line number changes again ? It will be back again :(
There must be a better way

[Redirion]

Checkstyle is stupid in this regard. In my opinion it should not enforce "final" modifier for primitives and String, as String is immutable.

[sauravrao637]

Any updates on this?

[Redirion]

it still feels like fixing the symptom but not the cause. But it is better than crashing and its well commented.