-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment replies #8443
Comment replies #8443
Conversation
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
@DUOLabs333 I think you should write code and build it in a proper IDE, like Android Studio or Intellij. The build process already tells you of checkstyle issues, for example, and I doubt it is doable to do the big requested changes by changing files not within an IDE. But thank you for the PR :-) |
…o longer remove showReplies when expanded
…ist_comments_item.xml
Here's one --- https://github.com/DUOLabs333/NewPipe/suites/6825870032/artifacts/262855249. It is nowhere near ready though. |
I tried it and it works well.
It is probably caused by the wrong implement in Youtube service in NewPipeExtractor, since the "getReplies" function is written long ago and may need adaption to fit in your code. I tried it in my service and did not encounter such problems. |
What I meant is that the planned UI hasn't been implemented yet. |
Sorry, it will come, but probably not for the next few versions (unless someone want to implement the comments page UI seen on YouTube). |
What I meant is that the replies will be on its own page (like the Youtube app, not like the Youtube website, or to be honest, most other mobile apps). |
@DUOLabs333 No time to work on this? Or some other reason? |
No, it's just without the UI implementation, the PR is stuck indefinitely. |
@DUOLabs333 But anyways, my question is did you ever get more than 10 replies to load? If so, could you point me to the function/lines? Thanks! |
No, as that is a problem with the Extractor (and would probably have to implement lazy loading in the frontend). |
If someone was to hypothetically work on this, what would be the best way to implement this? You obviously can't just get any arbitrary page --- maybe |
Hmmm, maybe. The code seems to already mostly exists here:
So it looks like you can create a new Page just from the URL and token, then feed the Page object to the |
I'll try to work on the Extractor to get more replies (it seem relatively simple, and something that can get merged in a reasonable amount of time). |
@golfinq From the look of the code mentioned, it seems that all of the work is already done --- just call |
Hmmm its been a while since I've looked at it, but from what I remember you
are correct; I personally couldn't figure out how to get that to actually
work. The replies were stored in a list-like structure and I tried some
stuff with copying the .page but it didn't work and I didnt have any other
ideas.
…On Sat, Sep 24, 2022, 8:48 PM DUO Labs ***@***.***> wrote:
@golfinq <https://github.com/golfinq> From the look of the code
mentioned, it seems that all of the work is already done --- just call
getReplies multiple times to get more replies. Is there something I'm
missing?
—
Reply to this email directly, view it on GitHub
<#8443 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOMH7IMZOFQ7L5N6SDCRUADV76OPRANCNFSM5XE2BVOQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Also to answer your previous question, if newpipe is still parsing the
mobile website then the next page of replies is just a matter of sending
the correct continuation token (I went through it a little ways up) with
the request that was used to get the original replies
…On Sat, Sep 24, 2022, 9:50 PM g f ***@***.***> wrote:
Hmmm its been a while since I've looked at it, but from what I remember
you are correct; I personally couldn't figure out how to get that to
actually work. The replies were stored in a list-like structure and I tried
some stuff with copying the .page but it didn't work and I didnt have any
other ideas.
On Sat, Sep 24, 2022, 8:48 PM DUO Labs ***@***.***> wrote:
> @golfinq <https://github.com/golfinq> From the look of the code
> mentioned, it seems that all of the work is already done --- just call
> getReplies multiple times to get more replies. Is there something I'm
> missing?
>
> —
> Reply to this email directly, view it on GitHub
> <#8443 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AOMH7IMZOFQ7L5N6SDCRUADV76OPRANCNFSM5XE2BVOQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Oh, I see the problem. |
I've been thinking about this, and a way to move forward with this without having to build a new UI would be to have at the bottom of the replies list tow buttons: "Load more replies", and "Collapse"/"Hide". This would allow an easy integration of |
For those that are not aware, this PR has been superseded by #9410 by the original author. |
What is it?
Description of the changes in your PR
A continuation of #7244
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence