Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment replies #8443

Closed
wants to merge 35 commits into from
Closed

Comment replies #8443

wants to merge 35 commits into from

Commits on May 27, 2022

  1. Added "Show Replies"

    @golfinq @DUOLabs333
    golfinq authored and DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    14ec5c0 View commit details
    Browse the repository at this point in the history

  2. Changed "Show Replies" to Resource

    @golfinq @DUOLabs333
    golfinq authored and DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    fe5c8e2 View commit details
    Browse the repository at this point in the history

  3. Remove redundant string resource 

    Co-authored-by: Mohammed Anas <triallax@tutanota.com>
    @golfinq @triallax @DUOLabs333
    2 people authored and DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    82e3772 View commit details
    Browse the repository at this point in the history

  4. Fixed behavior when scrolling

    @golfinq @DUOLabs333
    golfinq authored and DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    07bf1ec View commit details
    Browse the repository at this point in the history

  5. Moved downloading and reply code to new class

    @golfinq @DUOLabs333
    golfinq authored and DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    fc7695e View commit details
    Browse the repository at this point in the history

  6. Non-Blocking Downloading and Showing

    @golfinq @DUOLabs333
    golfinq authored and DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c3aa73b View commit details
    Browse the repository at this point in the history

  7. Fix some style issues

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    394655c View commit details
    Browse the repository at this point in the history

  8. Add setInfoItemList to RepliesHandler.java

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c183969 View commit details
    Browse the repository at this point in the history

  9. Replace {set,get}RepliesOpen with just assignment statements

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    b9468ec View commit details
    Browse the repository at this point in the history

  10. Fix style errors

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    9933fef View commit details
    Browse the repository at this point in the history

  11. Replaced {set,get}RepliesOpen with directly getting the replies

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    8693af1 View commit details
    Browse the repository at this point in the history

  12. Fix style errors

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    3cc4444 View commit details
    Browse the repository at this point in the history

  13. Fix line being too long

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    951530c View commit details
    Browse the repository at this point in the history

  14. Fix line being too long

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    6a037ce View commit details
    Browse the repository at this point in the history

  15. Fix line splitting issue

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    b058ab1 View commit details
    Browse the repository at this point in the history

  16. Removed info and trying something out

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    fb1c856 View commit details
    Browse the repository at this point in the history

  17. Replace TextView with NewPipeTextView, change showReplies text, and n… 

    …o longer remove showReplies when expanded
    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c6ff73d View commit details
    Browse the repository at this point in the history

  18. Don't download comments by default

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    89b4c57 View commit details
    Browse the repository at this point in the history

  19. Remove unused import android.widget.TextView

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    a2d4b5c View commit details
    Browse the repository at this point in the history

  20. Use org.schabi.newpipe.views.NewPipeTextView

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    ddf2010 View commit details
    Browse the repository at this point in the history

  21. Use org.schabi.newpipe.views.NewPipeTextView instead of TextView in l… 

    …ist_comments_item.xml
    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    22e72b9 View commit details
    Browse the repository at this point in the history

  22. Fix TextView import in CommentsInfoItemHolder.java

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    cf7aeb4 View commit details
    Browse the repository at this point in the history

  23. Remove channel_details strings from strings.xml

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    6efec1f View commit details
    Browse the repository at this point in the history

  24. Remove testing from CI for faster iteration (remember to revert later

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    6649784 View commit details
    Browse the repository at this point in the history

  25. Change showReplies default text

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    6800dd7 View commit details
    Browse the repository at this point in the history

  26. Add back show_replies in strings.xml

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    005573b View commit details
    Browse the repository at this point in the history

  27. Trying something

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    3eedd5b View commit details
    Browse the repository at this point in the history

  28. Try something else

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    3693402 View commit details
    Browse the repository at this point in the history

  29. Try something else

    @DUOLabs333
    DUOLabs333 committed May 27, 2022
    Configuration menu
    Copy the full SHA
    a59bc0c View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. Fix Replies toggle

    @DUOLabs333
    DUOLabs333 committed May 28, 2022
    Configuration menu
    Copy the full SHA
    645e140 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Make onSubscribe a no-op to fix compiling error

    @DUOLabs333
    DUOLabs333 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    943a629 View commit details
    Browse the repository at this point in the history

  2. Add push to comment-replies as a workflow trigger

    @DUOLabs333
    DUOLabs333 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d9e02b1 View commit details
    Browse the repository at this point in the history

  3. Fix style errors

    @DUOLabs333
    DUOLabs333 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    572cd15 View commit details
    Browse the repository at this point in the history

  4. Fix style errors

    @DUOLabs333
    DUOLabs333 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    028e7ab View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Last commit that works

    @DUOLabs333
    DUOLabs333 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    8f63646 View commit details
    Browse the repository at this point in the history