Use DisplayCompat.getMode().

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Use DisplayCompat.getMode() to get the current display mode. This method provides workarounds for retrieving the display size for Android TV devices.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Please, provide a "why" to your changes when opening PRs. I have no idea what DisplayCompat does and why this change would be an improvement, I only know it increases code size.

[Isira-Seneviratne]

Please, provide a "why" to your changes when opening PRs. I have no idea what DisplayCompat does and why this change would be an improvement, I only know it increases code size.

Sorry about that, I amended the change description.

[Stypox]

Thank you

This method provides workarounds for retrieving the display size for Android TV devices.

Didn't it already work before, or is there an issue this PR fixes? What is the difference in behaviour?

[Isira-Seneviratne]

Thank you

This method provides workarounds for retrieving the display size for Android TV devices.

Didn't it already work before, or is there an issue this PR fixes? What is the difference in behaviour?

The documentation mentions that some 4K TVs might have trouble running the framework code, so a workaround is provided in the method.

[Stypox]

According to the Android docs, Display.getSize() does something different than DisplayCompat.getMode().getPhysicalHeight()/display.getMode().getPhysicalHeight(). The first one gets the size of the screen used by the app (so removing system parts), while getPhysicalHeight() just returns the full screen size.

[Isira-Seneviratne]

According to the Android docs, Display.getSize() does something different than DisplayCompat.getMode().getPhysicalHeight()/display.getMode().getPhysicalHeight(). The first one gets the size of the screen used by the app (so removing system parts), while getPhysicalHeight() just returns the full screen size.

You're right, my bad. The backport implementation calls Display#getRealSize() on API levels 17-22 and Display#getSize() below API 17.

The documentation recommends using WindowManager#getCurrentWìndowMetrics() instead of Display#getSize(). I'll update this PR.

[Isira-Seneviratne]

I created a separate PR for the change I mentioned here: #8656