Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar scaling on thumbnail in playlists card view #9769

Merged
merged 1 commit into from Feb 25, 2023

Conversation

pratyaksh1610
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fix progress bar scaling on thumbnail in playlists card view

Before/After Screenshots/Screen Record

  • Before:

b1

  • After:
    a1

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Feb 9, 2023
@pratyaksh1610
Copy link
Contributor Author

@Stypox PTAL.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Stypox Stypox merged commit 6121229 into TeamNewPipe:dev Feb 25, 2023
@pratyaksh1610 pratyaksh1610 deleted the branch-9765 branch February 25, 2023 14:08
@Stypox Stypox mentioned this pull request Mar 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Progress bar on thumbnail in playlists is not properly scaled with card view
3 participants