Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of thumbnails on big screens to fit more grid columns #9858

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Feb 25, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Reverts a small piece of #9310, which introduced bigger grid thumbnail sizes on big screens, because some users reported not being happy about having too few grid columns. See #9310 (comment).

Before/After Screenshots/Screen Record

Before #9310 Before After
Before #9310 In #9310 After

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Reverts part of TeamNewPipe#9310, which introduced bigger grid thumbnail sizes on big screens, because some users reported not being happy about having too few grid columns. See TeamNewPipe#9310 (comment) .
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@s2r
Copy link

s2r commented Feb 25, 2023

Its better, but why not go back to 5 or 6 grids, or at least give that choice?

And if possible even removing a lot of the white space/border space between thumbnails, this from 3 to 4 is just mimicking mobile youtube, currently on newpipe it shows me a 3 grid and on m.youtube shows me a 4 grid but on m.youtube the 4 thumbnails seem even bigger than the 3 on newpipe just because there is is very little border space between the thumbnails, you guys have to give us better usability or else whats the point?

@peat80
Copy link

peat80 commented Feb 25, 2023

4 grids is the perfect size, please proceed. 🤔 😀

@Stypox
Copy link
Member Author

Stypox commented Feb 25, 2023

If in 0.24.1 you had 6 items per row, with this PR you would probably get 5.

@Stypox
Copy link
Member Author

Stypox commented Feb 25, 2023

Thank you for testing. I know this is not the optimal solution, but at least it will hopefully suit a bit better both people who want large thumbnails, and people who want more data on the screen at once. I'm merging this and soon we'll ship 0.25.1.

@Stypox Stypox merged commit f1a071b into TeamNewPipe:dev Feb 25, 2023
@s2r
Copy link

s2r commented Feb 25, 2023

not happy, but i still appreciate your work, thanks!

@Stypox Stypox deleted the fit-more-grid-columns branch February 26, 2023 01:04
@Stypox Stypox mentioned this pull request Mar 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Layout changed after upgrade to v.0.25.0 from 6 to 4 thumbnails per row !
3 participants