-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new logging type: "Admin only" #165
base: master
Are you sure you want to change the base?
Conversation
My only issue with this, is that you changed option 1 to the new option, instead of adding it to the end. This would completely break current installations of ULX. Well.. break is a harsh term, but it would change the behavior for everyone instead of giving them the opportunity to change it to the new setting. |
Changed it to add a new option rather than overwriting an old one. The reason I made it 1 before and not 3 is because I looked at them as a scale of permissibility; 0 being least permissive and 3 being the most permissive. This is untested and I changed it right before I'm about to go to bed, but if someone could test that'd be great. |
I'll merge this when someone can confirm that it works. |
This still works with no issues as-is; any chance this could finally be merged? |
This is a solution to #15, which has been a suggested (and planned) feature since 2013.
This is entirely untested, as I have no current way of testing this, so please let me know if it works.
Current settings (from Stickly Man!'s post):