Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new logging type: "Admin only" #165

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

iViscosity
Copy link

@iViscosity iViscosity commented Jun 2, 2020

This is a solution to #15, which has been a suggested (and planned) feature since 2013.

This is entirely untested, as I have no current way of testing this, so please let me know if it works.

Current settings (from Stickly Man!'s post):

; Echo modes:
; 0 - OFF No output to any players when an admin command is used
; 1 - ADMINS Output to admins only.
; 2 - ANONYMOUS Output to players without access to see who used the command (admins by default) similar to "(Someone) slapped Bob with 0 damage"
; 3 - FULL Output to players similar to "Foo slapped Bob with 0 damage"

@zpetty33
Copy link
Contributor

zpetty33 commented Aug 5, 2022

My only issue with this, is that you changed option 1 to the new option, instead of adding it to the end. This would completely break current installations of ULX. Well.. break is a harsh term, but it would change the behavior for everyone instead of giving them the opportunity to change it to the new setting.

@iViscosity
Copy link
Author

iViscosity commented Aug 15, 2022

Changed it to add a new option rather than overwriting an old one. The reason I made it 1 before and not 3 is because I looked at them as a scale of permissibility; 0 being least permissive and 3 being the most permissive.

This is untested and I changed it right before I'm about to go to bed, but if someone could test that'd be great.

@zpetty33
Copy link
Contributor

I'll merge this when someone can confirm that it works.

@thecraftianman
Copy link

This still works with no issues as-is; any chance this could finally be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants