Skip to content
This repository has been archived by the owner on Dec 23, 2022. It is now read-only.

Add support for other input "variants" #234

Closed
neilpoulin opened this issue Oct 15, 2018 · 1 comment
Closed

Add support for other input "variants" #234

neilpoulin opened this issue Oct 15, 2018 · 1 comment

Comments

@neilpoulin
Copy link
Contributor

TextInputs in material-ui support variants, such as outlined and filled. Using the chips component doesn't support all of these variants, but it would be great if it did. See here for examples. Implementation details can be found here

@leMaik
Copy link
Member

leMaik commented Oct 15, 2018

Sounds like a great improvement. 👍 A Pull Request would be highly appreciated.

neilpoulin added a commit to neilpoulin/material-ui-chip-input that referenced this issue Oct 15, 2018
leMaik pushed a commit that referenced this issue Oct 15, 2018
* outlined and filled variant support

* Update readme to include variant options. Fixes #234

* update ref and get rid of disableUnderline warning for variants that are not "standard"

* fix tests, update component snapshot

* revert formatting changes in ChipInput.spec

* alphabetize defaultProps

* alphabetize state

* revert styling changes

* add back in the USE_NEXT_TYPOGRAPHY_VARIANT in the test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants