-
-
Notifications
You must be signed in to change notification settings - Fork 208
openOnFocus breaks blur #73
Comments
Thank you for the bug report and locating the issue. 👍 Would you like to submit a PR that fixes it? |
…port openOnFocus (issue TeamWertarbyte#73)
I played around with this for a while. It is a minor timing issue. There might be a better way to handle this, but so far this is the simplest solution I've come up. |
handleInputBlur must pause before checking autocomplete status to support openOnFocus (issue #73)
Well, it's kind of an ugly hack, but that's the trade-off when you try to re-use components that aren't really made for making new components. 😕 Hopefully, this will improve when the next branch of Material-UI is ready and the chip input can be ported to use it. Thank you for the fix! 👍 |
Agreed, no problem. Will you be doing a new release soon that includes this fix? Would like to switch back to the official npm package. |
@cauld Thanks for the hint, I just released v0.12.2 which includes the fix. 👍 |
When setting openOnFocus to true the original collapsed state of the input is not reset when focus is lost. The label remains floated and the input is still underlined.
This setState block is never hit to set isFocused back to false.
You can see this in the open on focus storybook example. Click into the input and then tab out. Doing the same in other examples where openOnFocus is not used demonstrates the proper behavior.
The text was updated successfully, but these errors were encountered: