This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Upgrading material ui to 0.2.0 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
suggested changes
Dec 7, 2017
src/ChipInput.js
Outdated
| @@ -158,7 +158,7 @@ class ChipInput extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| this.autoComplete.handleItemTouchTap = (event, child) => { | |||
| this.autoComplete.handleItemClick = (event, child) => { | |||
There was a problem hiding this comment.
In order to keep compatible with v0.19.x, maybe we should also assign this.autoComplete.handleItemTouchTap = this.autoComplete.handleItemClick after that? 🤔
|
Thank you for your PR! 👍 We should stay backward-compatible to 0.19 (it's a low-hanging fruit), see my review. |
|
Yep thats true. Probably should revert the peer dependencies in package.json them aswell. Will do an update later 👍 |
|
So, now both versions are supported 👍 |
leMaik
approved these changes
Dec 8, 2017
|
Nice, thanks again! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Material-UI was upgraded to 0.2.0 removing all internal TouchTap references.
changed
this.autoComplete.handleItemTouchTap=>this.autoComplete.handleItemClick