Make autocomplete MenuItems customizable #173
Conversation
leMaik
changed the title
|
Edit: Now I get it. 👍 |
src/ChipInput.js
Outdated
| @@ -343,6 +343,16 @@ class ChipInput extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| if (typeof chip === 'object') { | |||
| if (chip[this.props.dataSourceConfig.text].length === 0 || chip[this.props.dataSourceConfig.value].length === 0) { | |||
There was a problem hiding this comment.
This can be removed, it's already handled below.
There was a problem hiding this comment.
You mean line 347? Or both?
There was a problem hiding this comment.
Removing everything would revert your PR. 😄 I mean lines 347–349
There was a problem hiding this comment.
It's not handled, because if we will not add such checking - we will get an empty chip by pressing "enter"
There was a problem hiding this comment.
Oh, you're right. It's fine then.
src/ChipInput.js
Outdated
| @@ -343,6 +343,16 @@ class ChipInput extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| if (typeof chip === 'object') { | |||
There was a problem hiding this comment.
Would you mind changing this to else if (typeof chip === 'object')?
There was a problem hiding this comment.
Did you push your changes? I don't see it yet.
There was a problem hiding this comment.
Wanted to push everything together
|
Anything else to fix? |
|
Maybe you could add a story to the storybook that shows how to use this to customize the menu items and ensure that no other stories break? |
|
Sure, also I've found one more bug, need to investigate |
|
I was mistaken, there were no bug, story added, stories did not break |
|
@darkchaplain Thank you very much! 👍 I'll publish a new release very soon. |
Fixes #172