This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Upgrade to @material-ui/core - 1.0.0-rc.1 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sulfurious Wow, this is a great first contribution to this project, thank you very much! 🎉 |
leMaik
suggested changes
May 17, 2018
| @@ -52,14 +53,13 @@ | |||
| "enzyme-to-json": "^3.2.2", | |||
| "gh-pages": "^1.0.0", | |||
| "jest": "^21.2.1", | |||
| "material-ui": "^1.0.0-beta.30", | |||
| "react": "^16.1.1", | |||
There was a problem hiding this comment.
React (and ReactDOM) should be updated to ^16.3.0, since Material-UI requires at least 16.3.0 as of rc.0
| "react": "^16.1.1", | ||
| "react-dom": "^16.1.1", | ||
| "react-test-renderer": "^16.2.0", | ||
| "standard": "^10.0.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "material-ui": "^1.0.0-beta.30", | ||
| "@material-ui/core": "^1.0.0-rc.1", | ||
| "react": "^16.0.0", |
| import { green } from 'material-ui/colors' | ||
| import Avatar from '@material-ui/core/Avatar' | ||
| import Chip from '@material-ui/core/Chip' | ||
| // import AutoComplete from '@material-ui/core/AutoComplete' |
There was a problem hiding this comment.
I think we can remove this line. AutoComplete will never be in @material-ui/core 😢
There was a problem hiding this comment.
Hey @leMaik I'll take care of the AutoComplete references and the React 16.3 requirement today
There was a problem hiding this comment.
@leMaik nm - you already took care of that :-)
leMaik
approved these changes
May 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to material-ui-next rc
https://github.com/mui-org/material-ui/releases/tag/v1.0.0-rc.1