This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Add chip's index in callbacks #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added chip's index in onRequestAdd and onRequestDelete callback on controlled ChipInput
leMaik
suggested changes
Jan 5, 2017
There was a problem hiding this comment.
Thank you very much for the PR! 👍
The chip index doesn't make sense in onRequestAdd because chips are just requested to be added and don't have an index, yet. Whatever controlls this could decide to use any index (e.g. prepending the chip or sorting the chips).
If you remove the index from onRequestAdd, I'll merge this.
|
@leMaik With pleasure. You did a good job with this component. |
leMaik
suggested changes
Jan 5, 2017
Passing index to a missing handleDeleteChip
|
I hope this time its fine :) ? |
|
@zazapeta Looks fine to me, thank you! 🎉 |
zazapeta
added a commit
to zazapeta/material-ui-chip-input
that referenced
this pull request
Jan 5, 2017
As the index is passed to the callback (onRequestDelete) : TeamWertarbyte#66
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added chip's index in onRequestAdd and onRequestDelete callback on controlled ChipInput