Initial code #1
Merged
Initial code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better package-level doc and/or README would be nice, but other than that 👍 |
ready4god2513
approved these changes
Jul 5, 2017
There was a problem hiding this comment.
As @Carpetsmoker I'd agree that it needs a bit of a readme along with use cases. But other than that looks good.
|
Let's merge this one then do an additional PR for docs/readme @flimzy so we can use it fully in desk (and launchpad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the basic 'errors' functionality from our httperr package.
I'm interested in feedback on whether anything should be changed as we separate this functionality from Desk, as it's a good opportunity to rename things (I've done a little renaming already), or changing other functionality slightly.
This leaves in our Desk-only httperr, some helper functions (which are mostly obsolete (i.e.
JSONString), and our error handler, which doesn't make senes to include in this package.