Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bun.sh with good defaults. #8407

Closed
wants to merge 3 commits into from
Closed

Add Bun.sh with good defaults. #8407

wants to merge 3 commits into from

Conversation

jtwebman
Copy link
Contributor

@jtwebman jtwebman commented Sep 5, 2023 •
edited
Loading

This adds Bun.sh 1.0.0 to the mix for TypeScript and JavaScript

@jtwebman
Copy link
Contributor Author

jtwebman commented Sep 7, 2023

Not sure why it is failing the tests? Maybe because it is from my fork?

@jtwebman jtwebman mentioned this pull request Sep 7, 2023
Open
@marcbarbosa
Copy link
Contributor

@jtwebman Since you are using a specific framework (Elysia), I believe we should move your implementation to frameworks/TypeScript/Elysia/ directory.

@NateBrady23
Copy link
Member

NateBrady23 commented Sep 11, 2023 •
edited
Loading

Yes, please move this to frameworks/TypeScript/elysia and update the benchmark_config.json to reflect. frameworks/TypeScript/bun would be reserved for a "vanilla" bun implementation without using another web framework.

@NateBrady23
Copy link
Member

closing in favor of #8480

@NateBrady23 NateBrady23 closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuvmuuv muuvmuuv muuvmuuv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtwebman @marcbarbosa @NateBrady23 @muuvmuuv