Support scoped modules. #48
Conversation
|
+1 on this one |
|
/me paws @gorillamania |
|
I switched to using @hemanth fork in my https://github.com/bahmutov/grunt-nice-package for now |
| @@ -62,7 +62,8 @@ QUnit.test("Dependencies Ranges", function() { | |||
| 'tilde-first': '~1.2', | |||
| 'x-version': '1.2.x', | |||
| 'tilde-top': '~1', | |||
| 'caret-top': '^1' | |||
| 'caret-top': '^1', | |||
| "@es-shims/api": "^1.0.0" | |||
There was a problem hiding this comment.
It would have been nice to follow the existing style of single quotes here...
There was a problem hiding this comment.
| "@es-shims/api": "^1.0.0" | |
| '@es-shims/api': '^1.0.0' |
|
ping @gorillamania would really appreciate getting this merged. I'd be happy to step up as a maintainer if you no longer have time to devote to this project :) |
|
Yes please! Note this has conflicts that prevent it from being merged. What is your npm username?I'll add you as a maintainer |
|
Glad to hear! I'm linusu on npm :) |
|
@LinusU I've added you as a collaborator on this repo and on NPM. Really appreciate the help! |
|
Meow. |
|
@hemanth I don't have permissions to push the suggestion (or merge conflict resolutions) to your branch. Would you be up for either doing that yourself or giving me permission to? I know it's been a long time, but I'd love to get this in 😄 |
JoshuaKGoldberg
added
the
status: waiting for author
|
@JoshuaKGoldberg I guess @bahmutov has a better fix :) |
|
Sorry, I don't follow - what's the better fix? |
|
Looks like my fork is deleted, so ^ :| |
|
Ah, gotcha. For context: I want to accept these changes and give you credit as the author. Do you want to re-fork and send a new PR? If not / you don't have time, no worries, I can always make them myself and list you as a co-author. But I'd feel bad doing that without giving you the opportunity to be the primary author. 🙂 |
|
@JoshuaKGoldberg That's ok, FOSS FTW! ❤️ |
^