Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oasis Welness W-12 #52

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Oasis Welness W-12 #52

wants to merge 26 commits into from

Conversation

Maria-Manuela
Copy link

@Maria-Manuela Maria-Manuela commented Apr 28, 2024

Netlify link

https://oasiswelnesscenter.netlify.app/

Collaborators

[Looziolooz]

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Maria-Manuela and Lorenzo, big congrats for completing your design! It looks ✨ awesome ✨ The site looks very close to the design and followed our requirements. How did you like Styled Components? Seems like you tackled it in the right way and implemented a great result, the button styled component is a great example! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further:

  • footer: alignment of buttons should be centered (justify-content: space-around)
  • on tablet and mobile: card corner doesn’t match the design

A requirement was to make the app responsive on screens starting from 320px:

  • on mobile: 95 - Keep an eye on responsiveness on small screen

Fix these little things to pass the assignment, really well done 👏

src/components/GlobalStyle.jsx Show resolved Hide resolved
@Maria-Manuela
Copy link
Author

I really loved to worked with styled components, for someone like me who loose the focus so easily, this gave more control over the styling. It´s a bless!
I fixed the issues and adjusted more things that were not according to the desgin. Now should look better also on the mobile @AntonellaMorittu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants