Parse services with '/'. Fixes #100 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ice-pull-requests #95 SUCCESS |
|
Hi, is there any reason this request hasn't been merged? Use of a snowball currently breaks Ice in its current state... |
|
Hi Tom,
Netflix does not accept pull request on Ice anymore.
We (Teevity) are shortly going to create a fork that will accept these
pending pull requests.
That should occur next week.
Nicolas
PS : It's a fork that will be separate from our current fork.
…--
Nicolas Fonrose | Teevity | Founder
+33.6.61.35.43.31
https://teevity.com - Cloud Costs Analytics built on NetflixOSS
twitter - @nfonrose / @Teevity
On Thu, Dec 8, 2016 at 2:58 PM, Tom Cartwright ***@***.***> wrote:
Hi, is there any reason this request hasn't been merged? Use of a snowball
currently breaks Ice in its current state...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#184 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACUpVC0Jy5hQFsnHycFjurpUt2vz8jBks5rGA0EgaJpZM4FyHeV>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a PR for this open here: #137
Sorry to open a new PR, but there are a couple of comments from review that I've addressed here. Please let me know if there's anything I can do to help get this merged.