Grouping resources with missing resourceId #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ice-pull-requests #98 SUCCESS |
|
Thanks for this update! |
NitriKx
approved these changes
Jul 25, 2017
NitriKx
added a commit
that referenced
this pull request
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that the Breakdown by Resource Groups feature was missing some costs and excluding certain products entirely, such as DynamoDB. Looking into the detailed AWS billing CSV, it appears as though some rows have an empty string in the ResourceId field. The Ice processor does not group these resources with missing ResourceId, which skips DynamoDB and other resources. This pull request removes that extra check for non-empty ResourceId, allowing for these resources to continue to be grouped by resource/product.