Further reduce size #1
Conversation
|
Thanks, I appreciate it! Nice to "internet meet" you, I think I started following you on Github in 2015 😂 I actually do use Rollup instead of Browserify for bundling nowadays, I only really use browserify in cases like this where I just need to pipe a bundle into a CLI tool for testing, like tape-run. I love the idea of microbundle, I hadn't run into it before! Were you comparing the microbundle output to browserify output? I'm cool with publishing minified output, but I have taken to publishing ES2015 instead of ES5 in the last year, assuming that anyone who still targets IE11 is using babel+preset-env. Should save some bytes there. I'll take a better look at this in a day or two. |
| @@ -0,0 +1,27 @@ | |||
| export default workFn => { | |||
| const hasIdleCallback = typeof requestIdleCallback==='function' | |||
There was a problem hiding this comment.
Yeah, this is more sensible than the window/global boilerplate I pasted in originally.
| @@ -8,7 +7,7 @@ const delay = require('delay') | |||
| const nextIdleCallback = () => { | |||
| const deferred = makeDeferred() | |||
|
|
|||
| idleish(deferred.resolve, 2000) | |||
| setTimeout(deferred.resolve, 2000); | |||
There was a problem hiding this comment.
My thinking was roughly "when testing in the browser, I do want to assert that events happened before the next idle callback". Arguably not worth the extra test complexity though.
If it's not worth it to keep the idle-callback-based assertion, we could just drop nextIdleCallback and replace it in the code with await delay(2000)
Hi Josh!
I really like this little library. I know you're partial to Browserify, but I figured I'd try running it through Microbundle to see if there was much of a size difference. I ended up getting it down to 166 bytes, which seems pretty good:
Totally up to you whether this seems like a build you could live with, just figured I'd send over the results since the size drop was >50%.
Cheers!