Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model settings #9

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Add model settings #9

merged 3 commits into from
Jan 19, 2023

Conversation

jwehrmann
Copy link
Member

Fix #8

@jwehrmann
Copy link
Member Author

In the future we could support pydantic schemas for managing settings for the most frequent models (openai completion, teia hub, etc).

martinduartemore
martinduartemore reviewed Jan 19, 2023
View reviewed changes
tests/test_ensemble.py
assert prompt_ff == prompt_str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace ☠️

martinduartemore
martinduartemore approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@martinduartemore martinduartemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!! 🥳

@martinduartemore martinduartemore merged commit 6dfa879 into master Jan 19, 2023
@martinduartemore martinduartemore deleted the add-model-settings branch January 19, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinduartemore martinduartemore martinduartemore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load temperature, stop_sequence and other arguments to the prompt object
2 participants
@jwehrmann @martinduartemore