This repository has been archived by the owner on Sep 14, 2024. It is now read-only.
WIP: Feature/loginflow #193
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
force-pushed
the
feature/loginflow
branch
from
2e911cb
to
feed63e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #190
first step towards #126
implements #45
This PR implements both the web based loginFlowV2 and QR based login.
Still needs some testing as a lot of things changed in the blocs :)
Self Singed certs are not really supported and I don't know if they will be :(
Still needs some UI fixups like the appBar of the webview and qrScanner
Also the QRscanner requires changes to the iOS app