Skip to content

Commit

Permalink
Fix for possibility of keyword sharing in language syntax
Browse files Browse the repository at this point in the history
* ISQLConstants
 * Can be used for SQL syntax and upper-case is the expected norm. Thus,
   the NULL keyword should be held in upper-case

* ISQLStringVisitor
 * Has no need to extend ISQLConstants since its implementations have
   access to their own syntax interfaces

* Synced with change in runtime-clients
  • Loading branch information
Paul Richardson committed Feb 15, 2013
1 parent 3875666 commit 8ec4b46
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public interface ISQLConstants {
String TABLE = "TABLE"; //$NON-NLS-1$
String EXEC = "EXEC"; //$NON-NLS-1$
String CONVERT = "CONVERT"; //$NON-NLS-1$
String NULL = "NULL"; //$NON-NLS-1$

String ENVELOPE_NS = "http://schemas.xmlsoap.org/soap/envelope/"; //$NON-NLS-1$
String ENVELOPE_NS_ALIAS = "soap"; //$NON-NLS-1$
Expand Down Expand Up @@ -96,8 +97,5 @@ public interface ISQLConstants {
String HEADER = "HEADER"; //$NON-NLS-1$
String SKIP = "SKIP"; //$NON-NLS-1$
String WIDTH = "width"; //$NON-NLS-1$

String NULL = "null"; //$NON-NLS-1$



}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
*
*/
public interface ISQLStringVisitor<LO extends ILanguageObject> extends ILanguageVisitor, ISQLConstants {
public interface ISQLStringVisitor<LO extends ILanguageObject> extends ILanguageVisitor {

/**
* Should the visitor fail to evaluate then this
Expand Down
2 changes: 1 addition & 1 deletion plugins/teiid/org.teiid.7.7.x
2 changes: 1 addition & 1 deletion plugins/teiid/org.teiid.8.2.x

0 comments on commit 8ec4b46

Please sign in to comment.