Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean ApiException.cs #646

Closed
karb0f0s opened this issue Mar 12, 2018 · 3 comments
Closed

Clean ApiException.cs #646

karb0f0s opened this issue Mar 12, 2018 · 3 comments
Assignees

Comments

@karb0f0s
Copy link
Member

We should clean this commented out part in
public static ApiRequestException FromApiResponse(ApiResponse apiResponse)
some exceptions already implemented, and there is no need to keep dead code for them, some not implemented yet, like case "bot was blocked by the user" but declared, which is misleading

@karb0f0s
Copy link
Member Author

Should BadRequestException and ForbiddenException abstract classes be renamed to BadRequestExceptionBase and ForbiddenExceptionBase?
Could then BadRequestException and ForbiddenException classes be used to throw general 400 and 403 errors?

@tuscen
Copy link
Member

tuscen commented Mar 18, 2018

@karb0f0s Agree, it makes sense to throw general BadRequestException and ForbiddenException when there is no particular exception type.

@karb0f0s karb0f0s mentioned this issue Mar 22, 2018
@karb0f0s karb0f0s removed the wip label Mar 27, 2018
@karb0f0s karb0f0s mentioned this issue Mar 28, 2018
@karb0f0s karb0f0s self-assigned this Mar 31, 2018
@karb0f0s karb0f0s added the wip label Mar 31, 2018
@karb0f0s karb0f0s closed this as completed Feb 8, 2019
@karb0f0s
Copy link
Member Author

karb0f0s commented Feb 8, 2019

Closed due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants