-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add articles about how to setup the new presets feature #82
Conversation
@winsmith I still haven't received feedback on these points, what's your take on them?
|
@winsmith I have now also finished up the Errors article, too. Please take a look. I have to admit there's some setup needed to get these presets working. I think it would be better if the official mobile SDKs (Swift, Android, Flutter) all came with some built-in code that make the setup process much simpler. For the "Purchases" in particular, I think our SDKs could include a currency converter with data we update every few months. We're not promising exact numbers anyways, and currency conversion doesn't change too much, so an update every few months or so should be fine. I could even write a script to automate it. But please read the articles first and give me feedback what you think. |
@winsmith I just updated the preset documentation based on the grand rename and added convenience methods for the Swift SDK. The other SDK might want to implement similar conveniences, but they are not required, the docs explain how to set it up without the convenience of the SDK. |
Hi sorry I somehow overlooked this PR. I think this is awesome. Here are some answers:
Yes, let's aim for that in the future, but not promise anything right now. I've already made some plans for error tracking and metrics and I want to be on the same page with you first.
I think links are totally allowed.
I don't want to commit to updating and maintaining these features for all SKDs right now, but we can talk about how to implement these kinds of features in a way that moves most of the work to the server so we don't duplicate it. Thanks for your work, I'm gonna merge this now, since I already merged the other PR 😅 |
@winsmith Thank you for merging! 🎉 Sure, we can talk about the currency conversion. But please note the original comment of this PR mentions that this should be merged together with TelemetryDeck/SwiftSDK#154, which is currently still unmerged. The documentation pages https://telemetrydeck.com/docs/articles/preset-purchases/, and https://telemetrydeck.com/docs/articles/preset-errors/ now state that convenience APIs are available in the Swift SDK which are not. We probably should merge TelemetryDeck/SwiftSDK#154 and make a new release. I can do it if I get the GO. |
I didn't see that one. You have the go :) |
Please take a look at this. I would like to discuss both the purchases article and the errors article. For example, the fact that there is some code I wrote there on how to get the country code, the purchase type, and how to convert other currencies to USD (which is a requirement of the feature for comparison reasons). We could also build these things into the different clients, or at least for the Swift client and update the documentation.
Note also that I put a link to a Freemium 3rd-party service as a convenience on how to do currency conversion for free. Not sure if outside links are allowed in the docs, so looking forward to your feedback.
This should be merged together with TelemetryDeck/SwiftSDK#154.